Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc for OpenAI Instrumentation to support OpenAI Compatible Platforms #3279

Merged
merged 5 commits into from
Feb 26, 2025

Conversation

gyliu513
Copy link
Member

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #3252

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Sorry, something went wrong.

Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the start, but I think this should include prior work here which is more exhaustive. That or create a wiki and link to it as this is more about the openai sdk than this instrumentation.

open-telemetry/semantic-conventions#1655

@gyliu513 gyliu513 changed the title Update doc for OpenAI Instrumentation to support DeepSeek Update doc for OpenAI Instrumentation to support OpenAI Compatible Platforms Feb 21, 2025
@gyliu513 gyliu513 marked this pull request as draft February 21, 2025 01:24
@gyliu513 gyliu513 marked this pull request as ready for review February 21, 2025 01:34
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Co-authored-by: Adrian Cole <64215+codefromthecrypt@users.noreply.github.com>
@shalevr shalevr merged commit 139f3e5 into open-telemetry:main Feb 26, 2025
694 checks passed
@gyliu513 gyliu513 deleted the ds branch February 26, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenAI Compatible Platform Instrumentation Support
9 participants