Add a test for mysql instrumentation using NoOpTracerProvider #1423
+24
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalevr
reviewed
Oct 31, 2022
instrumentation/opentelemetry-instrumentation-mysql/tests/test_mysql_integration.py
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-mysql/tests/test_mysql_integration.py
Outdated
Show resolved
Hide resolved
srikanthccv
reviewed
Nov 8, 2022
instrumentation/opentelemetry-instrumentation-mysql/tests/test_mysql_integration.py
Outdated
Show resolved
Hide resolved
# Conflicts: # CHANGELOG.md
…/opentelemetry-python-contrib into test-mysql-with-NoOpTracerProvider # Conflicts: # CHANGELOG.md
avzis
requested review from
srikanthccv and
shalevr
and removed request for
srikanthccv and
shalevr
srikanthccv
reviewed
Nov 28, 2022
srikanthccv
added
the
Skip Changelog
srikanthccv
approved these changes
Nov 28, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a test for mysql instrumentation using NoOpTracerProvider
Fixes #975
How Has This Been Tested?
tox -e test-instrumentation-mysql