Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exporter-logs/trace-otlp-grpc): fix error for missing dependency otlp-exporter-base #5412

Merged

Conversation

JamieDanielson
Copy link
Member

Which problem is this PR solving?

#5031 was a large refactor for OTLP exporters, and a dependency that was previously listed as a dev dependency is now required as a production dependency. Upgrading to experimental/v0.56.0 caused an error in Yarn PnP:

2025-01-09T01:35:53.432Z   220 U Error: @opentelemetry/exporter-logs-otlp-grpc tried to access @opentelemetry/otlp-exporter-base, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Short description of the changes

  • move @opentelemetry/otlp-exporter-base to be production dependency

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • I am working on a separate PR to add knip to this repo (we have it on contrib already) and make the other changes suggested by knip. For this one specifically I confirmed before and after for Unlisted Dependencies by adding this lint:deps command to the root package.json and running locally.

"lint:deps": "npx --yes knip@5.33.3 --dependencies --production --strict",

Sorry, something went wrong.

@JamieDanielson JamieDanielson requested a review from a team as a code owner January 31, 2025 22:44
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.64%. Comparing base (f9fda8b) to head (ffae5b9).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5412      +/-   ##
==========================================
- Coverage   94.65%   94.64%   -0.02%     
==========================================
  Files         317      317              
  Lines        8025     8025              
  Branches     1687     1687              
==========================================
- Hits         7596     7595       -1     
- Misses        429      430       +1     

see 1 file with indirect coverage changes

@JamieDanielson JamieDanielson changed the title fix(exporter-logs/trace-otlp-grpc): otlp-exporter-base is prod dependency fix(exporter-logs/trace-otlp-grpc): fix error for missing dependency otlp-exporter-base Jan 31, 2025
@pichlermarc pichlermarc added this pull request to the merge queue Feb 6, 2025
@pichlermarc
Copy link
Member

thank you @JamieDanielson - can you backport this to the v1.x branch? Then I'll cut a bugfix release.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 6, 2025
@pichlermarc pichlermarc added this pull request to the merge queue Feb 6, 2025
Merged via the queue into open-telemetry:main with commit e9f84cb Feb 6, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants