-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(instr-fetch): move fetch to use SEMATRR #4632
base: main
Are you sure you want to change the base?
Conversation
|
Hi @mmouru thanks for contributing into our effort to update semantic conventions. 🎉 Would you please complete this PR by adding a section in the README file listing the attributes used in this instrumentation? You can have a look at intrumentation-http README |
experimental/CHANGELOG.md
Outdated
* refactor(instr-fetch): move fetch to use SEMATRR [#4632](https://github.com/open-telemetry/opentelemetry-js/pull/4632) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* refactor(instr-fetch): move fetch to use SEMATRR [#4632](https://github.com/open-telemetry/opentelemetry-js/pull/4632) | |
* refactor(instrumentation-fetch): move fetch to use SEMATRR [#4632](https://github.com/open-telemetry/opentelemetry-js/pull/4632) |
Thank you @mmouru for your contribution :) Would you please add a section in the README file listing the attributes used in this instrumentation? Here is an example (you can omit the 3rd column) https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-instrumentation-http#semantic-conventions |
17240f3
to
301a207
Compare
done my bits |
| `HTTP_STATUS_CODE` | HTTP response status cod | | ||
| `HTTP_HOST` | The value of the HTTP host header | | ||
| `HTTP_USER_AGENT` | Value of the HTTP User-Agent header sent by the client | | ||
| `HTTP_SCHEME` | The URI scheme identifying the used protocol | | ||
| `HTTP_URL` | Full HTTP request URL | | ||
| `HTTP_METHOD` | HTTP request method | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be a actual strings, e.g. http.status_code
rather than HTTP_STATUS_CODE
.
Co-authored-by: Trent Mick <trentm@gmail.com>
Which problem is this PR solving?
Updates #4567
Short description of the changes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: