fix(instrumentation)!: pin import-in-the-middle@1.7.1 #4441
+31
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4441 +/- ##
=======================================
Coverage 92.22% 92.22%
=======================================
Files 336 336
Lines 9515 9515
Branches 2017 2017
=======================================
Hits 8775 8775
Misses 740 740 |
|
cc @trentm |
trentm
approved these changes
Jan 24, 2024
trentm
reviewed
Jan 24, 2024
Co-authored-by: Trent Mick <trentm@gmail.com>
This was referenced Jan 25, 2024
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
…#4441) * fix(instrumentation): pin import-in-the-middle@1.7.1 * fix(changelog): add changlog entry * Update experimental/CHANGELOG.md Co-authored-by: Trent Mick <trentm@gmail.com> * fix(changelog): additional details * fix(changelog): formatting * fix(changelog): lint --------- Co-authored-by: Trent Mick <trentm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
import-in-the-middle@1.7.2 and later includes a bug (nodejs/import-in-the-middle#57) where a property we use to distinguish ESM from CJS modules is not present, causing instrumentation to crash end-user apps.
This drops support for ESM instrumentation again for Node.js 18.19 and later.
Short description of the changes
pin import-in-the-middle@1.7.1
Type of change
Please delete options that are not relevant.