Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: run browser tests without circle #3328

Merged
merged 8 commits into from
Oct 14, 2022
Merged

ci: run browser tests without circle #3328

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
72aac65
ci: run browser tests without circle
dyladan Oct 13, 2022
1d410ba
Reduce scope
dyladan Oct 13, 2022
b3dd1f5
Bring back other tests
dyladan Oct 13, 2022
ae9bc2d
Apply to webworker tests
dyladan Oct 13, 2022
c7c06f6
Changelog
dyladan Oct 13, 2022
d4137ab
Use specific node version
dyladan Oct 13, 2022
74de346
Review comments
dyladan Oct 13, 2022
1aeac5a
Downgrade node in both places
dyladan Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 10 additions & 15 deletions .github/workflows/unit-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,6 @@ jobs:
run: npm run codecov
if: ${{ matrix.node_version == '14' }}
node-windows-tests:
strategy:
fail-fast: false
runs-on: windows-latest
env:
NPM_CONFIG_UNSAFE_PERM: true
Expand Down Expand Up @@ -96,15 +94,15 @@ jobs:
run: npm run test
browser-tests:
runs-on: ubuntu-latest
container:
image: circleci/node:16-browsers
env:
NPM_CONFIG_UNSAFE_PERM: true
steps:
- name: Permission Setup
run: sudo chmod -R 777 /github /__w
- name: Checkout
uses: actions/checkout@v3.0.2
uses: actions/checkout@v3

- uses: actions/setup-node@v3
with:
node-version: 18

- name: restore lerna
id: cache
Expand All @@ -126,8 +124,7 @@ jobs:

- name: Build 🔧
run: |
npm run compile
# run additional compilation variants
npx lerna run protos
npx lerna run compile

- name: Unit tests
Expand All @@ -136,15 +133,14 @@ jobs:
run: npm run codecov:browser
webworker-tests:
runs-on: ubuntu-latest
container:
image: circleci/node:16-browsers
env:
NPM_CONFIG_UNSAFE_PERM: true
steps:
- name: Permission Setup
run: sudo chmod -R 777 /github /__w
- name: Checkout
uses: actions/checkout@v3.0.2
- uses: actions/setup-node@v3
with:
node-version: 18

- name: restore lerna
id: cache
Expand All @@ -166,8 +162,7 @@ jobs:

- name: Build 🔧
run: |
npm run compile
# run additional compilation variants
npx lerna run protos
dyladan marked this conversation as resolved.
Show resolved Hide resolved
npx lerna run compile

- name: Unit tests
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ All notable changes to this project will be documented in this file.

### :house: (Internal)

* ci: run browser tests without circle [#3328](https://github.com/open-telemetry/opentelemetry-js/pull/3328) @dyladan

## 1.7.0

### :bug: (Bug Fix)
Expand Down