Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-trace): re-export sdk-trace-base in sdk-trace-node and web #3319

Merged
merged 1 commit into from Oct 11, 2022

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

Re-export sdk-trace-base members from sdk-trace-node and sdk-trace-web so that people using the platform SDK don't need to depends on the sdk-trace-base again.

Fixes #3318

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@legendecas legendecas requested a review from a team as a code owner October 11, 2022 02:46
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #3319 (002d113) into main (40ee382) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 002d113 differs from pull request most recent head 8a83f58. Consider uploading reports for the commit 8a83f58 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3319      +/-   ##
==========================================
- Coverage   93.45%   93.43%   -0.02%     
==========================================
  Files         241      241              
  Lines        7253     7253              
  Branches     1507     1507              
==========================================
- Hits         6778     6777       -1     
- Misses        475      476       +1     
Impacted Files Coverage Δ
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

@dyladan dyladan merged commit ef6fcdc into open-telemetry:main Oct 11, 2022
@legendecas legendecas deleted the docs/samplers branch October 11, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All samplers are deprecated
3 participants