Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser detector module #3292

Merged
merged 20 commits into from
Nov 2, 2022
Merged

Browser detector module #3292

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
714769f
Add Browser Detector Module
Abinet18 Oct 4, 2022
a3aa903
remove process resource attributes
Abinet18 Oct 4, 2022
f3ab8b7
minor fixes in test
Abinet18 Oct 4, 2022
a186422
Merge branch 'main' into Browser_Detector_Module
Abinet18 Oct 4, 2022
393e876
Update experimental/packages/opentelemetry-browser-detector/src/Brows…
Abinet18 Oct 11, 2022
edbf685
Update experimental/packages/opentelemetry-browser-detector/src/util.ts
Abinet18 Oct 11, 2022
1e68287
Use suggested deep strict equal for arrays
Abinet18 Oct 11, 2022
f1676c7
Merge branch 'main' into Browser_Detector_Module
Abinet18 Oct 11, 2022
c589f7d
Add language attribute
Abinet18 Oct 11, 2022
3d9914e
Convert object array for browser.brands into string array
Abinet18 Oct 13, 2022
4919c94
Merge branch 'main' into Browser_Detector_Module
Abinet18 Oct 13, 2022
642c0bf
type fix
Abinet18 Oct 14, 2022
7fe1c0c
fix test for brands
Abinet18 Oct 14, 2022
0d7f7b9
Merge branch 'main' into Browser_Detector_Module
Abinet18 Oct 14, 2022
583170c
Merge branch 'main' into Browser_Detector_Module
Abinet18 Oct 17, 2022
8c32393
remove unused pkgs, lint fix, add to changelog
Abinet18 Oct 21, 2022
b5ed1cf
Merge branch 'main' into Browser_Detector_Module
dyladan Oct 25, 2022
d6c5ffc
Merge branch 'main' into Browser_Detector_Module
dyladan Oct 27, 2022
1ed3b2b
fixup! add browser testing
legendecas Nov 1, 2022
fae5ec4
Merge branch 'main' into Browser_Detector_Module
legendecas Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion experimental/packages/opentelemetry-browser-detector/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ npm install --save @opentelemetry/opentelemetry-browser-detector

```js
import { Resource, detectResources } from '@opentelemetry/resources';
import { SemanticResourceAttributes } from '@opentelemetry/semantic-conventions';
import { SemanticResourceAttributes } from '@opentelemetry/semantic-conventions';
//...
import { browserDetector } from '@opentelemetry/opentelemetry-browser-detector';

Expand Down
21 changes: 19 additions & 2 deletions experimental/packages/opentelemetry-browser-detector/test/BrowserDetector.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,32 @@ describeBrowser('browserDetector()', () => {
language:'en-US',
userAgentData:{
platform:'platform',
brands:['brand1'],
brands:[
{
brand: 'Chromium',
version: '106'
},
{
brand: 'Google Chrome',
version: '106'
},
{
brand: 'Not;A=Brand',
version: '99'
}
],
mobile:false
}
});

const resource: Resource = await browserDetector.detect();
assertResource(resource, {
platform: 'platform',
brands: ['brand1'],
brands: [
MSNev marked this conversation as resolved.
Show resolved Hide resolved
'Chromium 106',
'Google Chrome 106',
'Not;A=Brand 99'
],
mobile: false,
language: 'en-US',
user_agent: 'dddd'
Expand Down