Skip to content

Commit

Permalink
ci: run browser tests without circle (#3328)
Browse files Browse the repository at this point in the history
* ci: run browser tests without circle

* Reduce scope

* Bring back other tests

* Apply to webworker tests

* Changelog

* Use specific node version

* Review comments

* Downgrade node in both places
  • Loading branch information
dyladan committed Oct 14, 2022
1 parent aa263e5 commit efb0275
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 15 deletions.
23 changes: 8 additions & 15 deletions .github/workflows/unit-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,6 @@ jobs:
run: npm run codecov
if: ${{ matrix.node_version == '14' }}
node-windows-tests:
strategy:
fail-fast: false
runs-on: windows-latest
env:
NPM_CONFIG_UNSAFE_PERM: true
Expand Down Expand Up @@ -96,15 +94,15 @@ jobs:
run: npm run test
browser-tests:
runs-on: ubuntu-latest
container:
image: circleci/node:16-browsers
env:
NPM_CONFIG_UNSAFE_PERM: true
steps:
- name: Permission Setup
run: sudo chmod -R 777 /github /__w
- name: Checkout
uses: actions/checkout@v3.0.2
uses: actions/checkout@v3

- uses: actions/setup-node@v3
with:
node-version: 16

- name: restore lerna
id: cache
Expand All @@ -126,8 +124,6 @@ jobs:
- name: Build 🔧
run: |
npm run compile
# run additional compilation variants
npx lerna run compile
- name: Unit tests
Expand All @@ -136,15 +132,14 @@ jobs:
run: npm run codecov:browser
webworker-tests:
runs-on: ubuntu-latest
container:
image: circleci/node:16-browsers
env:
NPM_CONFIG_UNSAFE_PERM: true
steps:
- name: Permission Setup
run: sudo chmod -R 777 /github /__w
- name: Checkout
uses: actions/checkout@v3.0.2
- uses: actions/setup-node@v3
with:
node-version: 16

- name: restore lerna
id: cache
Expand All @@ -166,8 +161,6 @@ jobs:
- name: Build 🔧
run: |
npm run compile
# run additional compilation variants
npx lerna run compile
- name: Unit tests
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ All notable changes to this project will be documented in this file.

### :house: (Internal)

* ci: run browser tests without circle [#3328](https://github.com/open-telemetry/opentelemetry-js/pull/3328) @dyladan

## 1.7.0

### :bug: (Bug Fix)
Expand Down

0 comments on commit efb0275

Please sign in to comment.