Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resource configuration factory #5757

Merged
merged 3 commits into from Aug 24, 2023

Conversation

jack-berg
Copy link
Member

Builds on #5751, #5687 #5399 by adding logic to interpret the resource portion of configuration schema.

@jack-berg jack-berg requested a review from a team as a code owner August 23, 2023 20:28
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage: 98.00% and project coverage change: +0.04% 🎉

Comparison is base (4aacac4) 91.35% compared to head (0ab8496) 91.40%.
Report is 1 commits behind head on main.

❗ Current head 0ab8496 differs from pull request most recent head 113dd33. Consider uploading reports for the commit 113dd33 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5757      +/-   ##
============================================
+ Coverage     91.35%   91.40%   +0.04%     
- Complexity     5196     5232      +36     
============================================
  Files           581      583       +2     
  Lines         15391    15491     +100     
  Branches       1474     1492      +18     
============================================
+ Hits          14061    14159      +98     
  Misses          915      915              
- Partials        415      417       +2     
Files Changed Coverage Δ
...xtension/incubator/fileconfig/ResourceFactory.java 90.00% <90.00%> (ø)
...ension/incubator/fileconfig/AttributesFactory.java 98.82% <98.82%> (ø)
.../fileconfig/OpenTelemetryConfigurationFactory.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg jack-berg merged commit 4fdd2ed into open-telemetry:main Aug 24, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants