-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds version to otel tracer instrumentation scope #5336
Conversation
While I'm here I also added same for opentracing, should that ever get the same javaagent testing treatment as opencensus. OT unfortunately lacks the same metadata class that OC has ( |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5336 +/- ##
============================================
- Coverage 91.07% 91.06% -0.01%
- Complexity 4863 4865 +2
============================================
Files 546 546
Lines 14371 14389 +18
Branches 1354 1354
============================================
+ Hits 13089 13104 +15
- Misses 892 895 +3
Partials 390 390
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
opencensus-shim/src/main/java/io/opentelemetry/opencensusshim/OpenTelemetrySpanBuilderImpl.java
Outdated
Show resolved
Hide resolved
opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/TracerShim.java
Outdated
Show resolved
Hide resolved
dcb10a0
to
53be282
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
To resolve open-telemetry/opentelemetry-java-instrumentation#7488 (comment)