address comments

open-telemetry · Aug 21, 2023 · 44da63b · 44da63b
1 parent 13e5fc6
commit 44da63b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...etheus/src/main/java/io/opentelemetry/exporter/prometheus/PrometheusMetricNameMapper.java b/...etheus/src/main/java/io/opentelemetry/exporter/prometheus/PrometheusMetricNameMapper.java
@@ -47,7 +47,7 @@ private static String mapToPrometheusName(MetricData rawMetric, PrometheusType p
             && !name.contains(prometheusEquivalentUnit);
     // trim counter's _total suffix so the unit is placed before it.
     if (prometheusType == PrometheusType.COUNTER && name.endsWith("_total")) {
-      name = name.substring(0, name.length() - 6);
+      name = name.substring(0, name.length() - "_total".length());
     }
     // append prometheus unit if not null or empty.
     if (shouldAppendUnit) {

diff --git a/exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Serializer.java b/exporters/prometheus/src/main/java/io/opentelemetry/exporter/prometheus/Serializer.java
@@ -570,7 +570,7 @@ String headerName(String name, MetricData rawMetric, PrometheusType type) {
       // header.
       String sanitizedOriginalName = NameSanitizer.INSTANCE.apply(rawMetric.getName());
       if (!sanitizedOriginalName.endsWith("_total") && (type == PrometheusType.COUNTER)) {
-        return name.substring(0, name.length() - 6);
+        return name.substring(0, name.length() - "_total".length());
       }
       return name;
     }