PR review

open-telemetry · Mar 14, 2024 · 35bcc88 · 35bcc88
1 parent 86d0bd2
commit 35bcc88
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/...rc/main/java/io/opentelemetry/sdk/autoconfigure/internal/EnvironmentResourceProvider.java b/...rc/main/java/io/opentelemetry/sdk/autoconfigure/internal/EnvironmentResourceProvider.java
@@ -24,6 +24,6 @@ public Resource createResource(ConfigProperties config) {
   public int order() {
     // Environment resource takes precedent over all other ResourceProviders except
     // ServiceInstanceIdResourceProvider.
-    return Integer.MAX_VALUE - 1;
+    return ServiceInstanceIdResourceProvider.ORDER - 1;
   }
 }
diff --git a/...n/java/io/opentelemetry/sdk/autoconfigure/internal/ServiceInstanceIdResourceProvider.java b/...n/java/io/opentelemetry/sdk/autoconfigure/internal/ServiceInstanceIdResourceProvider.java
@@ -23,9 +23,11 @@ public final class ServiceInstanceIdResourceProvider implements ConditionalResou
       AttributeKey.stringKey("service.instance.id");
 
   // multiple calls to this resource provider should return the same value
-  public static final Resource RANDOM =
+  private static final Resource RANDOM =
       Resource.create(Attributes.of(SERVICE_INSTANCE_ID, UUID.randomUUID().toString()));
 
+  static final int ORDER = Integer.MAX_VALUE;
+
   @Override
   public Resource createResource(ConfigProperties config) {
     return RANDOM;
@@ -40,6 +42,6 @@ public boolean shouldApply(ConfigProperties config, Resource existing) {
   public int order() {
     // Run after environment resource provider - only set the service instance ID if it
     // hasn't been set by any other provider.
-    return Integer.MAX_VALUE;
+    return ORDER;
   }
 }