Use HTTP instead of non-known method in http span name #9441

laurit · 2023-09-12T09:07:22Z

Resolves #9437

.../main/java/io/opentelemetry/instrumentation/api/instrumenter/http/HttpSpanNameExtractor.java

...ava/io/opentelemetry/instrumentation/api/instrumenter/http/HttpSpanNameExtractorBuilder.java

...io/opentelemetry/instrumentation/apachehttpclient/v4_3/ApacheHttpClientTelemetryBuilder.java

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

Use HTTP instead of non-known method in http span name

83d7f7e

laurit requested a review from a team as a code owner September 12, 2023 09:07

mateuszrzeszutek reviewed Sep 12, 2023

View reviewed changes

.../main/java/io/opentelemetry/instrumentation/api/instrumenter/http/HttpSpanNameExtractor.java Outdated Show resolved Hide resolved

laurit added 2 commits September 12, 2023 16:26

address review comment

c05e701

fix build

6aae06e

trask added this to the v1.30.0 milestone Sep 12, 2023

laurit mentioned this pull request Sep 12, 2023

Add HTTP server tests for non standard methods #9446

Merged

mateuszrzeszutek reviewed Sep 13, 2023

View reviewed changes

laurit and others added 2 commits September 13, 2023 13:41

Apply suggestions from code review

fb7ffe1

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

address review comments

e60bf48

mateuszrzeszutek approved these changes Sep 13, 2023

View reviewed changes

trask merged commit d157b68 into open-telemetry:main Sep 13, 2023
46 checks passed

Provide feedback