Emit both old and new metrics under dup setting #9320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
...c/main/java/io/opentelemetry/instrumentation/api/instrumenter/http/TemporaryMetricsView.java
Outdated
Show resolved
Hide resolved
Comment on lines
56
to
57
| createDurationHistogram( | ||
| meter, "http.client.request.duration", "The duration of the outbound HTTP request"); |
There was a problem hiding this comment.
I think you'll also need to change the condition on which the advice is applied: right now the buckets are not set if emitOldHttpSemconv is true, and that does not really make sense when we split the histograms.
There was a problem hiding this comment.
(just making sure: missing commit?)
.../src/main/java/io/opentelemetry/instrumentation/api/instrumenter/http/HttpClientMetrics.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to open-telemetry/opentelemetry-dotnet#4802 (comment)