Skip to content

Extract HTTP server experimental metrics to a separate class #9259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 30, 2023
Merged

Extract HTTP server experimental metrics to a separate class #9259

merged 4 commits into from
Aug 30, 2023
+956 −447

Conversation

mateuszrzeszutek
Copy link
Member

Resolves #9011

@mateuszrzeszutek mateuszrzeszutek requested a review from a team August 21, 2023 09:16
mateuszrzeszutek
mateuszrzeszutek commented Aug 21, 2023
View reviewed changes
...ary/src/main/java/io/opentelemetry/instrumentation/ratpack/v1_7/RatpackTelemetryBuilder.java
.setSpanStatusExtractor(HttpSpanStatusExtractor.create(httpAttributes))
.addAttributesExtractor(httpClientAttributesExtractorBuilder.build())
.addAttributesExtractors(additionalHttpClientExtractors)
.addOperationMetrics(HttpServerMetrics.get())
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really should add some tests for the HTTP metrics 🙈

@mateuszrzeszutek mateuszrzeszutek mentioned this pull request Aug 21, 2023
Closed
laurit
laurit approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@laurit laurit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be listed as a breaking change in changelog?

Mateusz Rzeszutek added 3 commits August 28, 2023 12:36
Extract HTTP server experimental metrics to a separate class
6774827
fix compilation failure

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
fc8db4b
add changelog
f92c5d2
@mateuszrzeszutek mateuszrzeszutek force-pushed the http-server-experimental-metrics branch from 55cfa20 to f92c5d2 Compare August 28, 2023 10:39
@mateuszrzeszutek
Copy link
Member Author

should this be listed as a breaking change in changelog?

Yeah, it probably should. I'll add something

@github-actions github-actions bot requested a review from theletterf August 28, 2023 10:39
@trask trask merged commit 133de24 into open-telemetry:main Aug 30, 2023
@mateuszrzeszutek mateuszrzeszutek deleted the http-server-experimental-metrics branch September 5, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurit laurit

@theletterf theletterf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract HTTP server experimental metrics to a separate class
3 participants
@mateuszrzeszutek @laurit @trask