Deprecate NetServerAttributesExtractor
#9156
Conversation
mateuszrzeszutek
changed the title
NetServerAttributesExtractor
| SemconvStability.emitStableHttpSemconv(), | ||
| SemconvStability.emitOldHttpSemconv()); |
There was a problem hiding this comment.
I've decided to have the new extractors emit the old spec as well: this will ease the transition from the old Net* classes, and will reduce the @SuppressWarnings("deprecation") annotations in our codebase.
The only attributes that are not covered by the new extractors are net.transport and net.sock.family (because the new attributes have different values), but there's like ~5 instrumentations using these anyway, so we'll just suppress deprecations there.
mateuszrzeszutek
force-pushed
the
deprecate-NetServerAttributesExtractor
branch
from
65cb9bb
to
cd74de0
Compare
mateuszrzeszutek
force-pushed
the
deprecate-NetServerAttributesExtractor
branch
from
cd74de0
to
fc58bc5
Compare
| @@ -10,7 +10,6 @@ | |||
| import io.opentelemetry.api.common.AttributesBuilder; | |||
| import io.opentelemetry.context.Context; | |||
| import io.opentelemetry.instrumentation.api.instrumenter.AttributesExtractor; | |||
| import io.opentelemetry.instrumentation.api.instrumenter.net.NetServerAttributesGetter; | |||
There was a problem hiding this comment.
I don't understand why you removed the import and just use the lengthy package name below. You did this in several places, so it looks intentional....it's just not clear to me how/why this helps the deprecation effort.
There was a problem hiding this comment.
Errorprone requires that when you use deprecated types.
I don't like this either, but I can kinda agree with that: using deprecated classes should look ugly, to encourage you to refactor the code that uses them
Another part of #9013
The
NetClientAttributesExtractorwill be done in the next (last for this issue) PR.