Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add javaagent to instrumentation bom #9026

Merged

Conversation

trask
Copy link
Member

@trask trask commented Jul 24, 2023

Resolves #8989

I don't remember why I excluded it originally in #6576.

@trask trask requested a review from a team as a code owner July 24, 2023 02:06
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember why I excluded it originally in #6576.

AFAIR as a suggestion that the javaagent is not meant to be used as a dependency. Still, as it turns out, sometimes it's useful to have that option.

@trask trask merged commit 5e004be into open-telemetry:main Sep 4, 2023
45 checks passed
@trask trask deleted the add-javaagent-to-instrumentation-bom branch September 4, 2023 04:14
@trask trask mentioned this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include opentelemetry-javaagent in the opentelemetry-bom
2 participants