Add library instrumentation for elasticsearch rest client 7 #8911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
commented
Jul 10, 2023
| } | ||
|
|
||
| private static Function<RestClient, RestClient> getProxyFactory(Class<?> clazz) { | ||
| for (Constructor<?> constructor : clazz.getDeclaredConstructors()) { |
There was a problem hiding this comment.
Here we expect that the class has a constructor that takes Header[] as second and List as third argument, these are the only 2 parameters that we need to fill with non default values. Alternatively we could skip the constructor call if there are too many changes in the constructors.
|
cc Elastic folks for visibility @AlexanderWert @estolfo @jackshirazi |
JonasKunz
approved these changes
Jul 11, 2023
...rc/main/java/io/opentelemetry/instrumentation/elasticsearch/rest/v7_0/RestClientWrapper.java
Show resolved
Hide resolved
laurit
force-pushed
the
elasticsearch-rest-library
branch
from
aa25ef4
to
7b35d89
Compare
laurit
force-pushed
the
elasticsearch-rest-library
branch
from
586e8d8
to
256cfef
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement library instrumentation for
elasticsearch-rest-7.0by using a byte-buddy bytcode proxy to wrap theRestClient. Using bytecode proxy allows to handle differences in the constructor signature ofRestClientso we don't need to have separate instrumentation for each change in the constructor.See #8867