fix JMX usage examples #7877
Merged
fix JMX usage examples #7877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the unit is a number, there's a ClassCastException. However, I'm not sure if updating the documentation is the right fix - `1` is also used in some internal config files - e.g. [tomcat](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/4db65b6d1f9e7fa430b700c38eb6abb5dcae7d26/instrumentation/jmx-metrics/javaagent/src/main/resources/jmx/rules/tomcat.yaml#L4) - it's an incompatible change for users, such as myself
PeterF778
approved these changes
Feb 22, 2023
|
@trask what about the imcompatible change?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the unit is a number, there's a ClassCastException.
However, I'm not sure if updating the documentation is the right fix
1is also used in some internal config files - e.g. tomcat