Add Jodd-Http instrumentation #7868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
breedx-splk
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Very cool @PhilKes thanks for the contribution. It looks good to me, with just a few small suggestions (and at least one missing unit test).
...a/io/opentelemetry/javaagent/instrumentation/joddhttp/v4_2/JoddHttpHttpAttributesGetter.java
Show resolved
Hide resolved
...t/src/main/java/io/opentelemetry/javaagent/instrumentation/joddhttp/v4_2/JoddHttpHelper.java
Outdated
Show resolved
Hide resolved
...a/io/opentelemetry/javaagent/instrumentation/joddhttp/v4_2/JoddHttpHttpAttributesGetter.java
Outdated
Show resolved
Hide resolved
.../io/opentelemetry/javaagent/instrumentation/joddhttp/v4_2/JoddHttpInstrumentationModule.java
Outdated
Show resolved
Hide resolved
...n/java/io/opentelemetry/javaagent/instrumentation/joddhttp/v4_2/JoddHttpInstrumentation.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/io/opentelemetry/javaagent/instrumentation/joddhttp/v4_2/JoddHttpHelper.java
Outdated
Show resolved
Hide resolved
...a/io/opentelemetry/javaagent/instrumentation/joddhttp/v4_2/JoddHttpHttpAttributesGetter.java
Outdated
Show resolved
Hide resolved
…pentelemetry-java-instrumentation into feat/jodd-http-instrumentation
mateuszrzeszutek
approved these changes
Feb 23, 2023
...n/java/io/opentelemetry/javaagent/instrumentation/joddhttp/v4_2/JoddHttpInstrumentation.java
Outdated
Show resolved
Hide resolved
...n/java/io/opentelemetry/javaagent/instrumentation/joddhttp/v4_2/JoddHttpInstrumentation.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #7629
This adds javaagent instrumentation for the jodd-http
HttpRequest.It creates
Http Client SpansandHttp Client Metrics, the lowest supported version isorg.jodd:jodd-http:4.2.0(most recent:6.3.0), since this is the first version of the library supporting java 8, having follow-redirect capability andHttpRequest#overwriteHeader()method. The instrumented method's signature and return typeHttpRequest#send()has not been modified since, and therefore the instrumentation works for alljodd-httpversions above4.2.0.Since this is my first contribution/instrumentation, I orientated myself on the
apache-httpclient-5.0instrumentation, but obviously I would be glad to get some feedback on this