Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement kafka client id and consumer id attributes #7860

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Implement kafka client id and consumer id attributes #7860

merged 3 commits into from
Feb 21, 2023

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Feb 20, 2023

Resolves #7771
Adds messaging.consumer_id and messaging.kafka.client_id attributes to kafka spans.

@laurit laurit requested a review from a team as a code owner February 20, 2023 14:15
@trask trask merged commit 85c541e into open-telemetry:main Feb 21, 2023
@laurit laurit deleted the kafka-client-id-attribute branch July 6, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug/Kafka Instrumentation missing some major attributes such as messaging.kafka.consumer.group
3 participants
@laurit @mateuszrzeszutek @trask