Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Liberty versions #7857

Merged
merged 5 commits into from
Mar 2, 2023
Merged

Conversation

fmhwong
Copy link
Contributor

@fmhwong fmhwong commented Feb 19, 2023

Open Liberty version 20.0.0.x are out of support. This PR removes 20.0.0.x and adds 22.0.0.x.

@fmhwong fmhwong requested a review from a team as a code owner February 19, 2023 23:30
@fmhwong
Copy link
Contributor Author

fmhwong commented Feb 21, 2023

It looks like we are missing the new images for the new Open Liberty versions. Is this something that an external contributor can do? Where can I find the instructions on how to build and push the smoke-test-servlet-liberty images?

@laurit
Copy link
Contributor

laurit commented Feb 22, 2023

@fmhwong These images are built automatically from

"liberty" to listOf(
ImageTarget(listOf("20.0.0.12"), listOf("hotspot", "openj9"), listOf("8", "11"), mapOf("release" to "2020-11-11_0736")),
// running configure.sh is failing while building the image with Java 19
ImageTarget(listOf("21.0.0.10"), listOf("hotspot"), listOf("8", "11", "17"), mapOf("release" to "2021-09-20_1900")),
ImageTarget(listOf("21.0.0.10"), listOf("openj9"), listOf("8", "11", "17"), mapOf("release" to "2021-09-20_1900")),
),
If you wish to adda new version your firstly need to send a pr that adds the new image. When it is merged the images will be published. After that you can use the images in you tests, you'll also have to update with the value that matches the newly built images.

@fmhwong
Copy link
Contributor Author

fmhwong commented Feb 22, 2023

Created PR #7878 for creating new Open Liberty images.

@trask
Copy link
Member

trask commented Feb 22, 2023

you can see the new tag "20230222.4247218894" now:

https://github.com/open-telemetry/opentelemetry-java-instrumentation/pkgs/container/opentelemetry-java-instrumentation%2Fsmoke-test-servlet-liberty

@fmhwong
Copy link
Contributor Author

fmhwong commented Feb 23, 2023

@trask Liberty tests passed. I didn't change the images for WebSphere. Is this an intermittent problem?

io.opentelemetry.testing.internal.armeria.common.ClosedSessionException

@laurit
Copy link
Contributor

laurit commented Mar 1, 2023

@fmhwong the problem is that was8.5.5.19 image build wasn't completely successful. Examine the output of https://github.com/open-telemetry/opentelemetry-java-instrumentation/actions/runs/4247069738/jobs/7384671536 We add configuration scripts to change the default port and install our default application. These didn't run successfully as wasmin seem to have failed to connect to the server.

@laurit
Copy link
Contributor

laurit commented Mar 2, 2023

@fmhwong we have updated websphere images. Use tag 20230301.4309128636 and update websphere versions to 8.5.5.22 and 9.0.5.14.

@fmhwong
Copy link
Contributor Author

fmhwong commented Mar 2, 2023

@laurit All checks passed. Thank you for your help!

@laurit laurit merged commit ee781f5 into open-telemetry:main Mar 2, 2023
@fmhwong fmhwong deleted the updateLibertyVersion branch March 3, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants