Implement messaging.kafka.* attributes spec (part 1)
#7824
Conversation
mateuszrzeszutek
force-pushed
the
messaging-kafka-attributes
branch
from
cf03fe9
to
6daaeb6
Compare
mateuszrzeszutek
changed the title
messaging.kafka.* attributes spec (part 1)
| @AutoValue | ||
| public abstract class ConsumerAndRecord<R> { | ||
|
|
||
| public static <R> ConsumerAndRecord<R> create(@Nullable Consumer<?, ?> consumer, R record) { |
There was a problem hiding this comment.
I also tried implementing the same metrics. Instead of consumer + record I went with record + consumerGroup + clientId. I suspect it will be hard to get access to consumer/producer in TracingConsumerInterceptor and TracingProducerInterceptor while the string values can be extracted in configure method.
Another potential issue is that ConsumerAndRecord could potentially be injected in multiple class loaders if for example kafka client is in parent and spring is in child. We have soled similar issues by moving such shared classes to bootstrap, but then we'd have library module depending on a bootstrap module which I think we don't have elsewhere.
There was a problem hiding this comment.
I suspect it will be hard to get access to consumer/producer in
TracingConsumerInterceptorandTracingProducerInterceptorwhile the string values can be extracted inconfiguremethod.
👍
Another potential issue is that
ConsumerAndRecordcould potentially be injected in multiple class loaders if for example kafka client is in parent and spring is in child.
This shouldn't be a problem; ConsumerAndRecord is not shared between different instrumentations, each one of them constructs a new value as needed.
Part 1 of #7771
It's a lot more than I initially expected it to be; I'll introduce the clientId attribute in part 2