Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gcp add gcr job support #1462

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Conversation

psx95
Copy link
Contributor

@psx95 psx95 commented Sep 18, 2024

Description:

Adds support for detecting Google Cloud Run Jobs environment. Cloud Run Jobs currently being detected as gcp_compute_engine.

Existing Issue(s):

Original Issue raised in another repository.

Testing:

  • Added unit tests pass.
  • Tested manually in conjunction with the changes here.

Outstanding items:

Need to update the dependency on com.google.cloud.opentelemetry:detector-resources-support before merging this PR.
None .

@psx95 psx95 force-pushed the gcp-add-gcr-job-support branch from 4ea7b97 to c8c421c Compare September 23, 2024 19:52
@psx95 psx95 marked this pull request as ready for review September 23, 2024 19:56
@psx95 psx95 requested a review from a team as a code owner September 23, 2024 19:56
@trask trask merged commit 81fce14 into open-telemetry:main Sep 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants