Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[collector] fix wrong extraContainers in generated yaml #1143

Merged

Conversation

JaredTan95
Copy link
Member

based #1139, fix wrong extraContainers in generated yaml:

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@JaredTan95 JaredTan95 requested a review from a team April 16, 2024 02:56

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, that's what I get for reviewing on my phone. Please revert the change to the example values.yaml.

…nt/deployment-values.yaml
@TylerHelmuth TylerHelmuth merged commit df92279 into open-telemetry:main Apr 16, 2024
3 checks passed
@JaredTan95 JaredTan95 deleted the fix_support_tpl_extraContainers branch April 16, 2024 23:16
blumamir added a commit to odigos-io/odigos that referenced this pull request Apr 17, 2024
It was introduced as a workaround fix until
open-telemetry/opentelemetry-helm-charts#1143 is
merged, due to an bug introduced via
open-telemetry/opentelemetry-helm-charts#1139
which broke odigos ci
12ushan pushed a commit to giffgaff/opentelemetry-helm-charts that referenced this pull request Jul 22, 2024
…ry#1143)

* fix open-telemetry#1139

* update

* revert examples changes

* Update charts/opentelemetry-collector/examples/daemonset-and-deployment/deployment-values.yaml

---------

Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants