Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the otlploghttp HTTP client #5224

Merged
merged 8 commits into from
Apr 19, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Apr 17, 2024

Without wanting to re-engineer the client this is almost entirely copied from the otlpmetrichttp client. The tests are also copied from there. The internal packages used there are flattened here. This is quite large, but given the copied nature and no clear way to break this up I have left it as is.

Part of #5057

@MrAlias MrAlias added area:logs Part of OpenTelemetry logs Skip Changelog PRs that do not require a CHANGELOG.md entry pkg:exporter:otlp Related to the OTLP exporter package labels Apr 17, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 81.88976% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 84.5%. Comparing base (94eb27f) to head (63a03f4).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5224     +/-   ##
=======================================
- Coverage   84.6%   84.5%   -0.1%     
=======================================
  Files        258     258             
  Lines      17224   17348    +124     
=======================================
+ Hits       14572   14675    +103     
- Misses      2349    2362     +13     
- Partials     303     311      +8     
Files Coverage Δ
exporters/otlp/otlplog/otlploghttp/config.go 94.9% <100.0%> (ø)
exporters/otlp/otlplog/otlploghttp/client.go 82.5% <81.6%> (-17.5%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: Reviewing it for me was quite easy for me given I was reading the same code this week when working on #5222 and #5221 😉 I think you did the right thing to flatten it out.

@MrAlias MrAlias merged commit 1ea4ee2 into open-telemetry:main Apr 19, 2024
26 of 27 checks passed
@MrAlias MrAlias deleted the otlploghttp-client branch April 19, 2024 17:17
@MrAlias MrAlias added this to the v1.26.0 milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logs Part of OpenTelemetry logs pkg:exporter:otlp Related to the OTLP exporter package Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants