-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the otlploghttp HTTP client #5224
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
area:logs
Part of OpenTelemetry logs
Skip Changelog
PRs that do not require a CHANGELOG.md entry
pkg:exporter:otlp
Related to the OTLP exporter package
labels
Apr 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5224 +/- ##
=======================================
- Coverage 84.6% 84.5% -0.1%
=======================================
Files 258 258
Lines 17224 17348 +124
=======================================
+ Hits 14572 14675 +103
- Misses 2349 2362 +13
- Partials 303 311 +8
|
MrAlias
force-pushed
the
otlploghttp-client
branch
from
April 17, 2024 22:29
19d58ab
to
fb8c932
Compare
MrAlias
force-pushed
the
otlploghttp-client
branch
from
April 18, 2024 15:25
c02b620
to
7021a32
Compare
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
April 18, 2024 16:09
pellared
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dashpole
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:logs
Part of OpenTelemetry logs
pkg:exporter:otlp
Related to the OTLP exporter package
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without wanting to re-engineer the client this is almost entirely copied from the
otlpmetrichttp
client. The tests are also copied from there. The internal packages used there are flattened here. This is quite large, but given the copied nature and no clear way to break this up I have left it as is.Part of #5057