Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baggage: more efficient member validation #5214

Merged
merged 8 commits into from
Apr 19, 2024

Commits on Apr 17, 2024

  1. baggage: more efficient Parse implementation

    Instead of performing many, many comparisons for each character in
    a key and value, create an array of 128 bits and test for membership
    in that array, which is quicker.
    
    Benchmarks on a Mac M1, ran 20 times.
    
    ```
    name                             old time/op    new time/op    delta
    New-8                               747ns ± 4%     741ns ± 3%    ~     (p=0.089 n=17+19)
    NewMemberRaw-8                     11.4ns ± 1%    10.9ns ± 1%  -4.67%  (p=0.000 n=17+19)
    Parse-8                             619ns ± 2%     603ns ± 1%  -2.54%  (p=0.000 n=18+18)
    String-8                           1.12µs ± 4%    1.09µs ± 2%  -2.65%  (p=0.000 n=19+18)
    ValueEscape/nothing_to_escape-8    6.93ns ± 1%    6.94ns ± 0%  +0.18%  (p=0.012 n=18+20)
    ValueEscape/requires_escaping-8    26.3ns ± 2%    26.1ns ± 1%  -0.91%  (p=0.000 n=19+19)
    ValueEscape/long_value-8            641ns ± 4%     595ns ± 1%  -7.14%  (p=0.000 n=18+17)
    ```
    kevinburkesegment committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    83d67ee View commit details
    Browse the repository at this point in the history
  2. add CHANGELOG entry

    kevinburkesegment committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    7c71c1d View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Update CHANGELOG.md

    pellared committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    714834b View commit details
    Browse the repository at this point in the history
  2. Update baggage/baggage.go

    pellared committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    ef77903 View commit details
    Browse the repository at this point in the history
  3. format

    pellared committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    72af477 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    aca55db View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Configuration menu
    Copy the full SHA
    33fe845 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2498094 View commit details
    Browse the repository at this point in the history