-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
baggage: more efficient member validation #5214
Merged
Merged
Commits on Apr 17, 2024
-
baggage: more efficient Parse implementation
Instead of performing many, many comparisons for each character in a key and value, create an array of 128 bits and test for membership in that array, which is quicker. Benchmarks on a Mac M1, ran 20 times. ``` name old time/op new time/op delta New-8 747ns ± 4% 741ns ± 3% ~ (p=0.089 n=17+19) NewMemberRaw-8 11.4ns ± 1% 10.9ns ± 1% -4.67% (p=0.000 n=17+19) Parse-8 619ns ± 2% 603ns ± 1% -2.54% (p=0.000 n=18+18) String-8 1.12µs ± 4% 1.09µs ± 2% -2.65% (p=0.000 n=19+18) ValueEscape/nothing_to_escape-8 6.93ns ± 1% 6.94ns ± 0% +0.18% (p=0.012 n=18+20) ValueEscape/requires_escaping-8 26.3ns ± 2% 26.1ns ± 1% -0.91% (p=0.000 n=19+19) ValueEscape/long_value-8 641ns ± 4% 595ns ± 1% -7.14% (p=0.000 n=18+17) ```
Configuration menu - View commit details
-
Copy full SHA for 83d67ee - Browse repository at this point
Copy the full SHA 83d67eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c71c1d - Browse repository at this point
Copy the full SHA 7c71c1dView commit details
Commits on Apr 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 714834b - Browse repository at this point
Copy the full SHA 714834bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef77903 - Browse repository at this point
Copy the full SHA ef77903View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72af477 - Browse repository at this point
Copy the full SHA 72af477View commit details -
Configuration menu - View commit details
-
Copy full SHA for aca55db - Browse repository at this point
Copy the full SHA aca55dbView commit details
Commits on Apr 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 33fe845 - Browse repository at this point
Copy the full SHA 33fe845View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2498094 - Browse repository at this point
Copy the full SHA 2498094View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.