Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdouttrace: Refine example #4872

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

pellared
Copy link
Member

@pellared pellared added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 30, 2024
@pellared pellared added the documentation Provides helpful information label Jan 30, 2024
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't this change the relationship between parent and child spans in the example? e.g. the second multiple will no longer be a child of the first multiply?

@pellared
Copy link
Member Author

won't this change the relationship between parent and child spans in the example? e.g. the second multiple will no longer be a child of the first multiply?

Should it be a child of the first multiply? The operation is done after the previous one. It is a "follow-up action".
Other example if you have HTTP request handling which does "serialization" and then "database insert" then is the "database insert" a child of "serialization"?

@dashpole
Copy link
Contributor

It probably shouldn't be a child of the first multiply.

@pellared pellared merged commit d9d9507 into open-telemetry:main Jan 31, 2024
25 checks passed
@pellared pellared deleted the refine-stdouttrace-example branch January 31, 2024 15:10
@MrAlias MrAlias added this to the v1.23.0 milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Provides helpful information Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants