Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option for resource attributes in metrics for prometheus exporter #4733

Merged
merged 9 commits into from
Dec 1, 2023
Merged

add option for resource attributes in metrics for prometheus exporter #4733

merged 9 commits into from
Dec 1, 2023

Commits on Nov 29, 2023

  1. add option for resource attributes in metrics for prometheus exporter 

    This PR adds the `WithResourceAsConstantLabels` option to the Prometheus exporter to allow users to configure resource attributes to be applied on every metric.

Fixes open-telemetry#4732

Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    20dd918 View commit details
    Browse the repository at this point in the history

  2. add test, changelog 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    c117380 View commit details
    Browse the repository at this point in the history

  3. add test for including only a subset of tags, dont use a ptr 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    fe4a72f View commit details
    Browse the repository at this point in the history

  4. Update exporters/prometheus/config.go 

    Co-authored-by: David Ashpole <dashpole@google.com>
    @dashpole
    Alex Boten and dashpole committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    f228b81 View commit details
    Browse the repository at this point in the history

  5. include feedback from review 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    cdde3f4 View commit details
    Browse the repository at this point in the history

  6. cache results 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    0237d61 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. removed map in favour of single keyVals 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    88d070c View commit details
    Browse the repository at this point in the history

  2. Update exporters/prometheus/config.go 

    Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
    @MrAlias
    Alex Boten and MrAlias committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    930ff09 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. move check outside the createResourceAttributes and rename func 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    b7cb11c View commit details
    Browse the repository at this point in the history