Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate opencensus bridge to errors.Join #4599

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Oct 9, 2023

Split from #4585

Instead of aggregating error strings, use errors.Join to combine them. Error wrapping works properly now, and tests can check for specific error types.

@dashpole dashpole added pkg:bridges Related to a bridge package Skip Changelog PRs that do not require a CHANGELOG.md entry enhancement New feature or request labels Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #4599 (3901413) into main (1074d64) will decrease coverage by 0.1%.
The diff coverage is 82.6%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4599     +/-   ##
=======================================
- Coverage   81.3%   81.3%   -0.1%     
=======================================
  Files        222     222             
  Lines      17692   17683      -9     
=======================================
- Hits       14401   14390     -11     
- Misses      2991    2993      +2     
  Partials     300     300             
Files Coverage Δ
bridge/opencensus/internal/ocmetric/metric.go 92.8% <82.6%> (-0.6%) ⬇️

... and 1 file with indirect coverage changes

@pellared pellared merged commit 960e6ab into open-telemetry:main Oct 11, 2023
24 checks passed
@MrAlias MrAlias added this to the v1.20.0 milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pkg:bridges Related to a bridge package Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants