Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in comments #4553

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Fix typos in comments #4553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
daf4f36
Fix minor typos in comments and test cases
CharlieTLe Sep 24, 2023
4df5485
Merge branch 'main' into codespell-9-24-2023
hanyuancheung Sep 26, 2023
b577054
Update meter_test.go
pellared Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion exporters/prometheus/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ func TestNewConfig(t *testing.T) {
for _, tt := range testCases {
t.Run(tt.name, func(t *testing.T) {
cfg := newConfig(tt.options...)
// only check the length of readerOpts, since they are not compareable
// only check the length of readerOpts, since they are not comparable
assert.Equal(t, len(tt.wantConfig.readerOpts), len(cfg.readerOpts))
cfg.readerOpts = nil
tt.wantConfig.readerOpts = nil
Expand Down
2 changes: 1 addition & 1 deletion sdk/metric/reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ type Reader interface {
// the SDK and stores it in out. An error is returned if this is called
// after Shutdown or if out is nil.
//
// This method needs to be concurrent safe, and the cancelation of the
// This method needs to be concurrent safe, and the cancellation of the
// passed context is expected to be honored.
Collect(ctx context.Context, rm *metricdata.ResourceMetrics) error
// DO NOT CHANGE: any modification will not be backwards compatible and
Expand Down