Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoC for pre-defined attribute filters #4433

Closed
wants to merge 1 commit into from
Closed

PoC for pre-defined attribute filters #4433

wants to merge 1 commit into from

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 10, 2023

No description provided.

@MrAlias MrAlias added pkg:attribute Related to the attribute package proposal labels Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #4433 (a9cee84) into main (b44a2bb) will decrease coverage by 0.1%.
The diff coverage is 0.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4433     +/-   ##
=======================================
- Coverage   81.2%   81.1%   -0.1%     
=======================================
  Files        247     248      +1     
  Lines      19996   20018     +22     
=======================================
- Hits       16248   16246      -2     
- Misses      3405    3429     +24     
  Partials     343     343
Files Changed Coverage Δ
attribute/filter.go 0.0% <0.0%> (ø)
attribute/set.go 77.7% <ø> (ø)

... and 1 file with indirect coverage changes

@MrAlias MrAlias mentioned this pull request Aug 11, 2023
Closed
@MrAlias
Copy link
Contributor Author

MrAlias commented Aug 14, 2023

Merged into #4444

@MrAlias MrAlias closed this Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie will be requested when the pull request is marked ready for review evantorrie is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM will be requested when the pull request is marked ready for review XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole will be requested when the pull request is marked ready for review dashpole is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod will be requested when the pull request is marked ready for review MadVikingGod is a code owner

@pellared pellared Awaiting requested review from pellared pellared will be requested when the pull request is marked ready for review pellared is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung will be requested when the pull request is marked ready for review hanyuancheung is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu will be requested when the pull request is marked ready for review dmathieu is a code owner

Assignees
No one assigned
Labels
pkg:attribute Related to the attribute package proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@MrAlias