Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the instrument aggregation compatibility table #4330

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Update the instrument aggregation compatibility table #4330

merged 1 commit into from
Jul 17, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jul 17, 2023

Use a check mark "✓" to indicate compatible instead of an "X" which can be misinterpreted as incompatible.

@MrAlias
Update the instrument agg comp table
c6901ab 
Use a check mark to indicate compatible instead of an "X" which can be
misinterpreted as incompatible.
@MrAlias MrAlias added documentation Provides helpful information pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics Skip Changelog PRs that do not require a CHANGELOG.md entry labels Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #4330 (c6901ab) into main (7467923) will decrease coverage by 0.1%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4330     +/-   ##
=======================================
- Coverage   83.4%   83.4%   -0.1%     
=======================================
  Files        184     184             
  Lines      14350   14350             
=======================================
- Hits       11979   11973      -6     
- Misses      2145    2151      +6     
  Partials     226     226
Impacted Files Coverage Δ
sdk/metric/pipeline.go 92.7% <ø> (ø)

... and 2 files with indirect coverage changes

@MrAlias
Copy link
Contributor Author

MrAlias commented Jul 17, 2023

Merging prior to the 24 hour time requirement given this is for internal docs and will conflict with #4332.

@MrAlias MrAlias merged commit 63dfc4c into open-telemetry:main Jul 17, 2023
30 checks passed
@MrAlias MrAlias deleted the hist-comp-doc branch July 17, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@MadVikingGod MadVikingGod MadVikingGod approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees
No one assigned
Labels
area:metrics Part of OpenTelemetry Metrics documentation Provides helpful information pkg:SDK Related to an SDK package Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v1.17.0/v0.40.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrAlias @dashpole @MadVikingGod