Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate instrument names when creating them #4210

Merged
merged 19 commits into from
Jun 9, 2023
Merged

Validate instrument names when creating them #4210

merged 19 commits into from
Jun 9, 2023

Commits on Jun 7, 2023

  1. validate instrument names when creating them

    @dmathieu
    dmathieu committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    214228d View commit details
    Browse the repository at this point in the history

  2. add changelog entry

    @dmathieu
    dmathieu committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    4db9c98 View commit details
    Browse the repository at this point in the history

  3. remove now invalid instrument name from prometheus test

    @dmathieu
    dmathieu committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    813f32f View commit details
    Browse the repository at this point in the history

  4. fix invalid names in meter_test

    @dmathieu
    dmathieu committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    b23b5a4 View commit details
    Browse the repository at this point in the history

  5. keep returning the instrument even if its name is invalid

    @dmathieu
    dmathieu committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    86fcd4b View commit details
    Browse the repository at this point in the history

  6. make invalid instrument name a known error

    @dmathieu
    dmathieu committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    42def55 View commit details
    Browse the repository at this point in the history

  7. bring back prometheus invalid instrument name test

    @dmathieu
    dmathieu committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    c8b8569 View commit details
    Browse the repository at this point in the history

  8. remove warning

    @dmathieu
    dmathieu committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    eda2c0d View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into validate-instrument-name

    @dmathieu
    dmathieu committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    5d57493 View commit details
    Browse the repository at this point in the history

  10. fix lint

    @dmathieu
    dmathieu committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    09c1104 View commit details
    Browse the repository at this point in the history

  11. move name validation into the lookup method

    @dmathieu
    dmathieu committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    ec8ccc5 View commit details
    Browse the repository at this point in the history

  12. fix lint again

    @dmathieu
    dmathieu committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    ff9f7c7 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Revert "move name validation into the lookup method" 

    This reverts commit ec8ccc5.
    @dmathieu
    dmathieu committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    1f5af24 View commit details
    Browse the repository at this point in the history

  2. rename ErrInvalidInstrumentName to ErrInstrumentName

    @dmathieu
    dmathieu committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    18ca7f4 View commit details
    Browse the repository at this point in the history

  3. switch to explicit validations, instead of a regexp

    @dmathieu
    dmathieu committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    eeaa0f5 View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG.md 

    Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
    @dmathieu @MrAlias
    dmathieu and MrAlias committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    da03c33 View commit details
    Browse the repository at this point in the history

  5. remove double check for empty name

    @dmathieu
    dmathieu committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    d6940d6 View commit details
    Browse the repository at this point in the history

  6. test validation shortcut with a single character

    @dmathieu
    dmathieu committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    711b9f9 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Merge branch 'main' into validate-instrument-name

    @MadVikingGod
    MadVikingGod committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    7e33fe3 View commit details
    Browse the repository at this point in the history