Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenCensus metric bridge to use the metric.Producer interface #3541

Merged
merged 4 commits into from
Dec 19, 2022

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Dec 15, 2022

Fixes #3504
Fixes #2204

This adds NewMetricProducer, and deprecates NewMetricExporter.

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #3541 (a441af1) into main (4014204) will increase coverage by 0.0%.
The diff coverage is 96.4%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3541   +/-   ##
=====================================
  Coverage   78.0%   78.1%           
=====================================
  Files        164     164           
  Lines      11799   11815   +16     
=====================================
+ Hits        9212    9232   +20     
+ Misses      2391    2387    -4     
  Partials     196     196           
Impacted Files Coverage Δ
internal/global/internal_logging.go 83.3% <87.5%> (+8.3%) ⬆️
bridge/opencensus/metric.go 92.5% <100.0%> (+7.5%) ⬆️
sdk/trace/batch_span_processor.go 81.9% <0.0%> (+0.8%) ⬆️

bridge/opencensus/metric.go Outdated Show resolved Hide resolved
bridge/opencensus/metric.go Outdated Show resolved Hide resolved
bridge/opencensus/metric_test.go Outdated Show resolved Hide resolved
@MrAlias MrAlias added this to the Metric v0.35.0 milestone Dec 19, 2022
@MrAlias MrAlias merged commit a724cf8 into open-telemetry:main Dec 19, 2022
@dashpole dashpole deleted the opencensus_producer branch December 19, 2022 21:20
@MrAlias MrAlias mentioned this pull request Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:bridges Related to a bridge package
Projects
No open projects
3 participants