Allow '/' character in instrument names

open-telemetry · Sep 12, 2023 · b1e6bbf · b1e6bbf
1 parent 69611bd
commit b1e6bbf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/sdk/metric/meter.go b/sdk/metric/meter.go
@@ -28,7 +28,7 @@ import (
 
 var (
 	// ErrInstrumentName indicates the created instrument has an invalid name.
-	// Valid names must consist of 255 or fewer characters including alphanumeric, _, ., -, and start with a letter.
+	// Valid names must consist of 255 or fewer characters including alphanumeric, _, ., -, / and start with a letter.
 	ErrInstrumentName = errors.New("invalid instrument name")
 )
 
@@ -262,8 +262,8 @@ func validateInstrumentName(name string) error {
 		return nil
 	}
 	for _, c := range name[1:] {
-		if !isAlphanumeric(c) && c != '_' && c != '.' && c != '-' {
-			return fmt.Errorf("%w: %s: must only contain [A-Za-z0-9_.-]", ErrInstrumentName, name)
+		if !isAlphanumeric(c) && c != '_' && c != '.' && c != '-' && c != '/' {
+			return fmt.Errorf("%w: %s: must only contain [A-Za-z0-9_.-/]", ErrInstrumentName, name)
 		}
 	}
 	return nil

diff --git a/sdk/metric/meter_test.go b/sdk/metric/meter_test.go
@@ -775,9 +775,12 @@ func TestValidateInstrumentName(t *testing.T) {
 		{
 			name: "nam.",
 		},
+		{
+			name: "nam/e",
+		},
 		{
 			name:    "name!",
-			wantErr: fmt.Errorf("%w: name!: must only contain [A-Za-z0-9_.-]", ErrInstrumentName),
+			wantErr: fmt.Errorf("%w: name!: must only contain [A-Za-z0-9_.-/]", ErrInstrumentName),
 		},
 		{
 			name:    longName,