address feedback

open-telemetry · Jul 17, 2023 · 85e2d50 · 85e2d50
1 parent f5d61f0
commit 85e2d50
Showing 1 changed file with 0 additions and 27 deletions.
diff --git a/sdk/metric/internal/aggregate/sum_test.go b/sdk/metric/internal/aggregate/sum_test.go
@@ -197,25 +197,6 @@ func TestPreComputedDeltaSum(t *testing.T) {
 	// measured(+): 20, previous(-): 1
 	want.DataPoints = []metricdata.DataPoint[int64]{point[int64](attrs, 19)}
 	metricdatatest.AssertAggregationsEqual(t, want, agg.Aggregation(), opt)
-
-	// Filtered values should not persist.
-	agg.Aggregate(5, attrs)
-	// measured(+): 5, previous(-): 20
-	want.DataPoints = []metricdata.DataPoint[int64]{point[int64](attrs, -15)}
-	metricdatatest.AssertAggregationsEqual(t, want, agg.Aggregation(), opt)
-
-	// Order should not affect measure.
-	// Filtered should add.
-	agg.Aggregate(3, attrs)
-	agg.Aggregate(7, attrs)
-	agg.Aggregate(10, attrs)
-	// measured(+): 20, previous(-): 5
-	want.DataPoints = []metricdata.DataPoint[int64]{point[int64](attrs, 15)}
-	metricdatatest.AssertAggregationsEqual(t, want, agg.Aggregation(), opt)
-	agg.Aggregate(7, attrs)
-	// measured(+): 7, previous(-): 20
-	want.DataPoints = []metricdata.DataPoint[int64]{point[int64](attrs, -13)}
-	metricdatatest.AssertAggregationsEqual(t, want, agg.Aggregation(), opt)
 }
 
 func TestPreComputedCumulativeSum(t *testing.T) {
@@ -246,14 +227,6 @@ func TestPreComputedCumulativeSum(t *testing.T) {
 	agg.Aggregate(10, attrs)
 	want.DataPoints = []metricdata.DataPoint[int64]{point[int64](attrs, 18)}
 	metricdatatest.AssertAggregationsEqual(t, want, agg.Aggregation(), opt)
-
-	// Order should not affect measure.
-	// Duplicates should add.
-	agg.Aggregate(3, attrs)
-	agg.Aggregate(7, attrs)
-	agg.Aggregate(10, attrs)
-	want.DataPoints = []metricdata.DataPoint[int64]{point[int64](attrs, 20)}
-	metricdatatest.AssertAggregationsEqual(t, want, agg.Aggregation(), opt)
 }
 
 func TestEmptySumNilAggregation(t *testing.T) {