Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelzap: Implement Uint methods on encoder #5609

Merged
merged 12 commits into from
May 21, 2024

Conversation

khushijain21
Copy link
Contributor

Part of #5191

Pre-work #5279

This PR implements uInt methods objectEncoder

@khushijain21 khushijain21 requested review from pellared and a team as code owners May 19, 2024 06:19
Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.3%. Comparing base (a91e60b) to head (163e46d).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5609   +/-   ##
=====================================
  Coverage   63.2%   63.3%           
=====================================
  Files        194     194           
  Lines      11983   11998   +15     
=====================================
+ Hits        7585    7606   +21     
+ Misses      4181    4175    -6     
  Partials     217     217           
Files Coverage Δ
bridges/otelzap/encoder.go 89.0% <100.0%> (+15.5%) ⬆️

@pellared pellared added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label May 20, 2024
@pellared

This comment was marked as resolved.

@pellared pellared merged commit 52ee3c4 into open-telemetry:main May 21, 2024
23 checks passed
khushijain21 added a commit to khushijain21/opentelemetry-go-contrib that referenced this pull request May 22, 2024
Part of
open-telemetry#5191

Pre-work
open-telemetry#5279

This PR implements `uInt` methods `objectEncoder`

---------

Co-authored-by: Robert Pająk <pellared@hotmail.com>
@khushijain21 khushijain21 deleted the encoderuint branch May 24, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants