Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otelzap: Implement methods on objectEncoder #5602

Merged
merged 22 commits into from
May 20, 2024
Merged

otelzap: Implement methods on objectEncoder #5602

merged 22 commits into from
May 20, 2024

Conversation

khushijain21
Copy link
Contributor

Part of #5191

Pre-work #5279

This PR implements some more methods on objectEncoder

khushijain21 and others added 13 commits May 16, 2024 16:53
@khushijain21
otelzap: Implement methods on Object Encoder
5f18478
@khushijain21 @pellared
Update bridges/otelzap/core_test.go
bada129 
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@khushijain21
add more methods
626d7de
@khushijain21
Merge branch 'encoder2' of https://github.com/khushijain21/openteleme…
9b87b81 
…try-go-contrib into encoder2
@khushijain21
removed
c26ff31
@khushijain21
code refactor
2a3c97d
@XSAM
Merge branch 'main' into encoder2
c714009
@khushijain21
removed doc commentS
8da639f
@khushijain21
Merge branch 'encoder2' of https://github.com/khushijain21/openteleme…
7180516 
…try-go-contrib into encoder3
@khushijain21
remove doc comments
4b1974c
@khushijain21
Merge branch 'encoder2' of https://github.com/khushijain21/openteleme…
5e802ac 
…try-go-contrib into encoder3
@khushijain21
add complex methods on encoder
83be071
@khushijain21
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
518ff13 
…y-go-contrib into encoder3
@khushijain21 khushijain21 requested review from pellared and a team as code owners May 17, 2024 07:40
@codecov Codecov
Copy link

codecov bot commented May 17, 2024 •
edited

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 63.2%. Comparing base (040472f) to head (e9bfdc0).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5602   +/-   ##
=====================================
  Coverage   63.2%   63.2%           
=====================================
  Files        194     194           
  Lines      11973   11983   +10     
=====================================
+ Hits        7571    7585   +14     
+ Misses      4185    4181    -4     
  Partials     217     217
Files Coverage Δ
bridges/otelzap/encoder.go 73.4% <76.1%> (+17.0%) ⬆️

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label May 17, 2024
pellared
pellared reviewed May 17, 2024
View reviewed changes
bridges/otelzap/encoder.go Outdated Show resolved Hide resolved
bridges/otelzap/encoder.go Outdated Show resolved Hide resolved
@MrAlias MrAlias added the bridge: zap Related to the zap bridge label May 17, 2024
@pellared pellared merged commit 8c03dfa into open-telemetry:main May 20, 2024
23 checks passed
zailic pushed a commit to zailic/opentelemetry-go-contrib that referenced this pull request May 20, 2024
@khushijain21 @pellared @zailic
otelzap: Implement methods on objectEncoder (open-telemetry#5602)
4258921 
Part of open-telemetry#5191

---------

Co-authored-by: Robert Pająk <pellared@hotmail.com>
@khushijain21 khushijain21 deleted the encoder3 branch May 22, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pellared pellared pellared approved these changes

@XSAM XSAM XSAM approved these changes

Assignees
No one assigned
Labels
bridge: zap Related to the zap bridge Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@khushijain21 @pellared @XSAM @dmathieu @MrAlias