Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add support for logger provider configuration #5427

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

codeboten
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 94.38202% with 5 lines in your changes missing coverage. Please review.

Project coverage is 64.1%. Comparing base (9ddea00) to head (d9838e4).

Current head d9838e4 differs from pull request most recent head a9db3af

Please upload reports for the commit a9db3af to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5427     +/-   ##
=======================================
+ Coverage   63.8%   64.1%   +0.2%     
=======================================
  Files        194     195      +1     
  Lines      12239   12276     +37     
=======================================
+ Hits        7820    7872     +52     
+ Misses      4197    4181     -16     
- Partials     222     223      +1     
Files Coverage Δ
config/trace.go 96.4% <100.0%> (ø)
config/config.go 82.2% <71.4%> (-2.8%) ⬇️
config/log.go 96.2% <96.2%> (ø)

... and 7 files with indirect coverage changes

@codeboten codeboten marked this pull request as ready for review April 26, 2024 15:52
@codeboten codeboten force-pushed the codeboten/config-logger-provider branch 2 times, most recently from 97d2336 to 90e4518 Compare May 14, 2024 21:28
config/log.go Outdated Show resolved Hide resolved
config/log_test.go Show resolved Hide resolved
config/log.go Outdated Show resolved Hide resolved
config/log.go Show resolved Hide resolved
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten force-pushed the codeboten/config-logger-provider branch from e246edf to 4918dab Compare May 31, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants