-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service resource detector #5424
base: main
Are you sure you want to change the base?
Service resource detector #5424
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5424 +/- ##
=====================================
Coverage 62.3% 62.3%
=====================================
Files 189 190 +1
Lines 11575 11584 +9
=====================================
+ Hits 7219 7226 +7
- Misses 4146 4147 +1
- Partials 210 211 +1
|
} | ||
} | ||
|
||
matched, err := regexp.MatchString("^[A-Fa-f0-9]{8}-[A-Fa-f0-9]{4}-[A-Fa-f0-9]{4}-[A-Fa-f0-9]{4}-[A-Fa-f0-9]{12}$", uuid) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tip for the future: you can add /i
at the end of the regex to make it case insensitive, this way you don't need to add A-F
and a-f
, which have the risk of forgetting one of them
Fixes #5423
This PR adds a resource detector for detecting
service.instance.id
which sets its values according to to experimental semantic conventions for service attributes:service.instance.id