otelgrpc: add custom attributes to the stats handler #5133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inigohu
force-pushed
the
feature/otelgrpc-custom-attr
branch
2 times, most recently
from
ce0e777
to
aac80ca
Compare
inigohu
requested review from
dashpole,
hanyuancheung and
a team
as code owners
inigohu
force-pushed
the
feature/otelgrpc-custom-attr
branch
from
aac80ca
to
a508d4d
Compare
inigohu
force-pushed
the
feature/otelgrpc-custom-attr
branch
2 times, most recently
from
eacf0ac
to
d594e0c
Compare
inigohu
force-pushed
the
feature/otelgrpc-custom-attr
branch
from
d594e0c
to
99ea5ca
Compare
|
Friendly ping @dashpole @hanyuancheung |
|
This looks like it does a lot more than just add a labeler. Would you mind doing general refactoring in its own PR? |
inigohu
force-pushed
the
feature/otelgrpc-custom-attr
branch
2 times, most recently
from
e4f7d19
to
c82b0f0
Compare
Sure. I have simplified this PR by adding only the labeler. |
dashpole
reviewed
Jun 4, 2024
instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go
Outdated
Show resolved
Hide resolved
inigohu
force-pushed
the
feature/otelgrpc-custom-attr
branch
2 times, most recently
from
26b7c36
to
3d28af9
Compare
dashpole
reviewed
Jun 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5133 +/- ##
=====================================
Coverage 63.8% 63.9%
=====================================
Files 194 194
Lines 12236 12248 +12
=====================================
+ Hits 7817 7830 +13
+ Misses 4197 4196 -1
Partials 222 222
|
inigohu
force-pushed
the
feature/otelgrpc-custom-attr
branch
from
3d28af9
to
2d79ff4
Compare
inigohu
force-pushed
the
feature/otelgrpc-custom-attr
branch
from
2d79ff4
to
a6b8d67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3894