fix: custom attributes are ignored - #5084

[zailic]

OK... i opened a new PR for #5084 issue, as i shot myself in a foot trying to modify a previous commit that I pushed under another github user.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.5%. Comparing base (2ca9fcb) to head (3b158db).

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #5129   +/-   ##
=====================================
  Coverage   63.5%   63.5%           
=====================================
  Files        194     194           
  Lines      12059   12061    +2     
=====================================
+ Hits        7663    7667    +4     
+ Misses      4179    4178    -1     
+ Partials     217     216    -1     

Files	Coverage Δ
instrumentation/net/http/otelhttp/handler.go	91.9% <100.0%> (+<0.1%)	⬆️
instrumentation/net/http/otelhttp/labeler.go	100.0% <100.0%> (+11.7%)	⬆️
instrumentation/net/http/otelhttp/transport.go	97.4% <100.0%> (+<0.1%)	⬆️

[zailic]

@dmathieu - Could you please let me know if there's any changes or information from me in order to move forward with this PR?

[zailic]

Hi @dmathieu , when you have a moment, could you please take a look at this PR? Thank you!

[dmathieu]

There is still a lint issue.

[zailic]

There is still a lint issue.

@dmathieu Merged the latest main branch changes and did a make precommit on my local...I hope this will solve the failing build step issue.

[dmathieu]

The issue appears to be that go.sum is changed by the linter. You may have to run go mod tidy

[zailic]

The issue appears to be that go.sum is changed by the linter. You may have to run go mod tidy

it's strange i did a make precommit(which incluedes a go mod tidy step) before the push...

[zailic]

The issue appears to be that go.sum is changed by the linter. You may have to run go mod tidy
@dmathieu - i pushed the modified go.sum - could you please give it another try?

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: zailic / name: Ionut Ovidiu Zailic (0c3d401)
• ✅ login: MrAlias / name: Tyler Yahn (3b158db)
• ✅ login: dmathieu / name: Damien Mathieu (852f3ed)

[dmathieu]

Something is wrong with your merges.

[zailic]

Something is wrong with your merges.

strange... i only merged latest main branch changes without having any conflicts

[zailic]

@dmathieu - should I wait for more reviewers, to get this merged? It's a little bit painful to keep this branch up to date. Thanks.

[dmathieu]

PRs need at least 2 reviewers, and can only be merged by a maintainer. So yes, more reviews are required.
Also, while the diff of your PR looks good, there are a lot of commits attached to it, which cause a CLA issue. It won't be mergeable that way.

[zailic]

PRs need at least 2 reviewers, and can only be merged by a maintainer. So yes, more reviews are required. Also, while the diff of your PR looks good, there are a lot of commits attached to it, which cause a CLA issue. It won't be mergeable that way.

Understood. Thanks! I've squashed bloating commits.

[zailic]

Hi @Aneurysm9,

I hope you're doing well. I would appreciate your review when you have a moment.

Thanks!