Fix httpconv changes in docs from semconv 1.17 to 1.20 #4799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
added
the
Skip Changelog
dmathieu
force-pushed
the
httpconv-doc-changes
branch
from
d10a8fe
to
785dce2
Compare
MrAlias
approved these changes
Jan 8, 2024
|
Ping @Aneurysm9 @hanyuancheung for second review before merge. |
pellared
approved these changes
Jan 29, 2024
dmathieu
force-pushed
the
httpconv-doc-changes
branch
from
6b9e584
to
e5eacaa
Compare
|
@MadVikingGod PTAL |
MadVikingGod
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4320 upgraded semconv in otelhttp from 1.17.0 to 1.20.0, which has breaking changes:
EnduserIDKeyhas been removed.HTTPFlavorKeyhas been removed.HTTPUserAgentKeyhas been renamed toUserAgentOriginalKey.This PR updates the doc comments accordingly.