Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otelhttp: use plain fields #4615

Merged
merged 2 commits into from
Nov 21, 2023
Merged

otelhttp: use plain fields #4615

merged 2 commits into from
Nov 21, 2023

Conversation

ash2k
Copy link
Contributor

@ash2k ash2k commented Nov 20, 2023

Fixes #4502.

@ash2k ash2k requested review from Aneurysm9, dmathieu and a team as code owners November 20, 2023 09:03
@ash2k ash2k changed the title otelhttp: use pain fields otelhttp: use plain fields Nov 20, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 20, 2023 •
edited

Codecov Report

Merging #4615 (9eba222) into main (698903f) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4615     +/-   ##
=======================================
- Coverage   80.9%   80.9%   -0.1%     
=======================================
  Files        150     150             
  Lines      10355   10349      -6     
=======================================
- Hits        8382    8376      -6     
  Misses      1831    1831             
  Partials     142     142
Files Coverage Δ
instrumentation/net/http/otelhttp/handler.go 87.3% <100.0%> (-0.4%) ⬇️

pellared
pellared approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@pellared pellared left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 I just left two minor comments.

CHANGELOG.md Outdated Show resolved Hide resolved
instrumentation/net/http/otelhttp/handler.go Outdated Show resolved Hide resolved
@ash2k ash2k requested a review from pellared November 20, 2023 11:54
@pellared pellared added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Nov 20, 2023
pellared
pellared approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pellared pellared merged commit f699179 into open-telemetry:main Nov 21, 2023
22 checks passed
@ash2k ash2k deleted the fields-for-measures branch November 21, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@pellared pellared pellared approved these changes

@hanyuancheung hanyuancheung hanyuancheung approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees
No one assigned
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

otelhttp: maps are used when just normal fields could be
4 participants
@ash2k @dmathieu @pellared @hanyuancheung