Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Go 1.19 #4352

Merged
merged 3 commits into from Oct 2, 2023
Merged

Drop support for Go 1.19 #4352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ef6c2c
Drop support for Go 1.19
MrAlias Sep 29, 2023
c3d417e
Add change to changelog
MrAlias Sep 29, 2023
d9dfdc9
Merge branch 'main' into drop-go-1.19
pellared Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Expand Up @@ -117,7 +117,7 @@ jobs:
compatibility-test:
strategy:
matrix:
go-version: ["~1.21.1", "~1.20.8", 1.19]
go-version: ["~1.21.1", "~1.20.8"]
os: [ubuntu-latest, macos-latest, windows-latest]
# GitHub Actions does not support arm* architectures on default
# runners. It is possible to acomplish this with a self-hosted runner
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -13,6 +13,11 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- Add the new `go.opentelemetry.io/contrib/instrgen` package to provide auto-generated source code instrumentation. (#3068, #3108)
- Add `"go.opentelemetry.io/contrib/samplers/jaegerremote".WithSamplingStrategyFetcher` which sets custom fetcher implementation. (#4045)

### Changed

- Dropped compatibility testing for [Go 1.19].
The project no longer guarantees support for this version of Go. (#4352)

### Fixed

- The `go.opentelemetry.io/contrib/samplers/jaegerremote` sampler does not panic when the default HTTP round-tripper (`http.DefaultTransport`) is not `*http.Transport`. (#4045)
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Expand Up @@ -140,7 +140,7 @@ go-mod-tidy/%: DIR=$*
go-mod-tidy/%:
@echo "$(GO) mod tidy in $(DIR)" \
&& cd $(DIR) \
&& $(GO) mod tidy -compat=1.19
&& $(GO) mod tidy -compat=1.20

.PHONY: misspell
misspell: | $(MISSPELL)
Expand Down
5 changes: 0 additions & 5 deletions README.md
View file
Open in desktop
Expand Up @@ -50,19 +50,14 @@ This project is tested on the following systems.
| ------- | ---------- | ------------ |
| Ubuntu | 1.21 | amd64 |
| Ubuntu | 1.20 | amd64 |
| Ubuntu | 1.19 | amd64 |
| Ubuntu | 1.21 | 386 |
| Ubuntu | 1.20 | 386 |
| Ubuntu | 1.19 | 386 |
| MacOS | 1.21 | amd64 |
| MacOS | 1.20 | amd64 |
| MacOS | 1.19 | amd64 |
| Windows | 1.21 | amd64 |
| Windows | 1.20 | amd64 |
| Windows | 1.19 | amd64 |
| Windows | 1.21 | 386 |
| Windows | 1.20 | 386 |
| Windows | 1.19 | 386 |

While this project should work for other systems, no compatibility guarantees
are made for those systems currently.
Expand Down
2 changes: 1 addition & 1 deletion bridges/prometheus/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/bridges/prometheus

go 1.19
go 1.20

require (
github.com/prometheus/client_golang v1.17.0
Expand Down
2 changes: 1 addition & 1 deletion detectors/aws/ec2/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/detectors/aws/ec2

go 1.19
go 1.20

require (
github.com/aws/aws-sdk-go v1.45.19
Expand Down
2 changes: 1 addition & 1 deletion detectors/aws/ecs/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/detectors/aws/ecs

go 1.19
go 1.20

require (
github.com/brunoscheufler/aws-ecs-metadata-go v0.0.0-20220812150832-b6b31c6eeeaf
Expand Down
2 changes: 1 addition & 1 deletion detectors/aws/eks/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/detectors/aws/eks

go 1.19
go 1.20

require (
github.com/stretchr/testify v1.8.4
Expand Down
2 changes: 1 addition & 1 deletion detectors/aws/lambda/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/detectors/aws/lambda

go 1.19
go 1.20

require (
github.com/stretchr/testify v1.8.4
Expand Down
2 changes: 1 addition & 1 deletion detectors/gcp/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/detectors/gcp

go 1.19
go 1.20

require (
cloud.google.com/go/compute/metadata v0.2.3
Expand Down
2 changes: 1 addition & 1 deletion exporters/autoexport/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/exporters/autoexport

go 1.19
go 1.20

require (
github.com/stretchr/testify v1.8.4
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
@@ -1,3 +1,3 @@
module go.opentelemetry.io/contrib

go 1.19
go 1.20
2 changes: 1 addition & 1 deletion instrgen/driver/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrgen/driver

go 1.19
go 1.20

replace go.opentelemetry.io/contrib/instrgen => ../

Expand Down
2 changes: 1 addition & 1 deletion instrgen/driver/testdata/interface/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrgen/testdata/interface

go 1.18
go 1.20

replace go.opentelemetry.io/contrib/instrgen => ../../..

Expand Down
2 changes: 1 addition & 1 deletion instrgen/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrgen

go 1.19
go 1.20

require (
go.opentelemetry.io/otel v1.19.0
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/aws/aws-lambda-go/otellambda/example/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-lambda-go/otellambda/example

go 1.18
go 1.20

replace (
go.opentelemetry.io/contrib/detectors/aws/lambda => ../../../../../../detectors/aws/lambda
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/aws/aws-lambda-go/otellambda/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-lambda-go/otellambda

go 1.19
go 1.20

require (
github.com/aws/aws-lambda-go v1.41.0
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/aws/aws-lambda-go/otellambda/test/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-lambda-go/otellambda/test

go 1.19
go 1.20

replace (
go.opentelemetry.io/contrib/detectors/aws/lambda => ../../../../../../detectors/aws/lambda
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/aws/aws-lambda-go/otellambda/xrayconfig/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-lambda-go/otellambda/xrayconfig

go 1.19
go 1.20

replace (
go.opentelemetry.io/contrib/detectors/aws/lambda => ../../../../../../detectors/aws/lambda
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/example/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/example

go 1.18
go 1.20

replace go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws => ../

Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws

go 1.19
go 1.20

require (
github.com/aws/aws-sdk-go-v2 v1.21.0
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/test/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/test

go 1.19
go 1.20

require (
github.com/aws/aws-sdk-go-v2 v1.21.0
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/emicklei/go-restful/otelrestful/example/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/emicklei/go-restful/otelrestful/example

go 1.18
go 1.20

replace (
go.opentelemetry.io/contrib/instrumentation/github.com/emicklei/go-restful/otelrestful => ../
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/emicklei/go-restful/otelrestful/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/emicklei/go-restful/otelrestful

go 1.19
go 1.20

replace go.opentelemetry.io/contrib/propagators/b3 => ../../../../../propagators/b3

Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/emicklei/go-restful/otelrestful/test/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/emicklei/go-restful/otelrestful/test

go 1.19
go 1.20

require (
github.com/emicklei/go-restful/v3 v3.11.0
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/gin-gonic/gin/otelgin/example/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin/example

go 1.18
go 1.20

replace (
go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin => ../
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/gin-gonic/gin/otelgin/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin

go 1.19
go 1.20

replace go.opentelemetry.io/contrib/propagators/b3 => ../../../../../propagators/b3

Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/gin-gonic/gin/otelgin/test/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin/test

go 1.19
go 1.20

require (
github.com/gin-gonic/gin v1.9.1
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/gorilla/mux/otelmux/example/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux/example

go 1.18
go 1.20

replace go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux => ../

Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/gorilla/mux/otelmux/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux

go 1.19
go 1.20

require (
github.com/felixge/httpsnoop v1.0.3
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/gorilla/mux/otelmux/test/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux/test

go 1.19
go 1.20

require (
github.com/gorilla/mux v1.8.0
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/labstack/echo/otelecho/example/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho/example

go 1.18
go 1.20

replace (
go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho => ../
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/labstack/echo/otelecho/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho

go 1.19
go 1.20

replace go.opentelemetry.io/contrib/propagators/b3 => ../../../../../propagators/b3

Expand Down
2 changes: 1 addition & 1 deletion instrumentation/github.com/labstack/echo/otelecho/test/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho/test

go 1.19
go 1.20

require (
github.com/labstack/echo/v4 v4.11.1
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo

go 1.19
go 1.20

require (
go.mongodb.org/mongo-driver v1.12.1
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/test/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo/test

go 1.19
go 1.20

require (
github.com/stretchr/testify v1.8.4
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/google.golang.org/grpc/otelgrpc/example/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/example

go 1.18
go 1.20

replace go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc => ../

Expand Down
2 changes: 1 addition & 1 deletion instrumentation/google.golang.org/grpc/otelgrpc/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc

go 1.19
go 1.20

require (
github.com/stretchr/testify v1.8.4
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/google.golang.org/grpc/otelgrpc/test/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/test

go 1.19
go 1.20

require (
github.com/stretchr/testify v1.8.4
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/gopkg.in/macaron.v1/otelmacaron/example/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/gopkg.in/macaron.v1/otelmacaron/example

go 1.18
go 1.20

replace (
go.opentelemetry.io/contrib/instrumentation/gopkg.in/macaron.v1/otelmacaron => ../
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/gopkg.in/macaron.v1/otelmacaron/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/gopkg.in/macaron.v1/otelmacaron

go 1.19
go 1.20

replace go.opentelemetry.io/contrib/propagators/b3 => ../../../../propagators/b3

Expand Down
2 changes: 1 addition & 1 deletion instrumentation/gopkg.in/macaron.v1/otelmacaron/test/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/gopkg.in/macaron.v1/otelmacaron/test

go 1.19
go 1.20

require (
github.com/stretchr/testify v1.8.4
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/host/example/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/host/example

go 1.18
go 1.20

replace go.opentelemetry.io/contrib/instrumentation/host => ../

Expand Down
2 changes: 1 addition & 1 deletion instrumentation/host/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/host

go 1.19
go 1.20

require (
github.com/shirou/gopsutil/v3 v3.23.9
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/net/http/httptrace/otelhttptrace/example/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace/example

go 1.18
go 1.20

replace (
go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace => ../
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/net/http/httptrace/otelhttptrace/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace

go 1.19
go 1.20

require (
github.com/google/go-cmp v0.5.9
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/net/http/httptrace/otelhttptrace/test/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace/test

go 1.19
go 1.20

require (
github.com/stretchr/testify v1.8.4
Expand Down
2 changes: 1 addition & 1 deletion instrumentation/net/http/otelhttp/example/go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/example

go 1.18
go 1.20

replace go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp => ../

Expand Down