-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert prometheus bridge readme to godocs #4348
Conversation
a22b066
to
eed9b8b
Compare
@pellared I wanted to make the example print something out to the console, but that requires importing the stdoutmetric package. Is there a way to add dependencies only for the example? |
No 😢 We had the same problem in the sdk/metric example. We decided to simply use a ManualReader instead. See https://github.com/open-telemetry/opentelemetry-go/blob/9bbefc6cc31995c7bdd37c69eb153fc2201c3562/sdk/metric/example_test.go#L47-L50 |
eed9b8b
to
ea42a4c
Compare
ea42a4c
to
d568022
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion. Awaiting for a non-Splunk approval.
Should we also add "Bridges" here: https://github.com/open-telemetry/opentelemetry-go-contrib#contents? |
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Done 35c2be6 |
Codecov Report
@@ Coverage Diff @@
## main #4348 +/- ##
=====================================
Coverage 82.2% 82.3%
=====================================
Files 144 144
Lines 10002 10002
=====================================
+ Hits 8229 8232 +3
+ Misses 1634 1632 -2
+ Partials 139 138 -1 |
fixes #4339