Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert prometheus bridge readme to godocs #4348

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

dashpole
Copy link
Contributor

fixes #4339

@dashpole dashpole added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Sep 26, 2023
@dashpole dashpole force-pushed the prom_bridge_docs branch 2 times, most recently from a22b066 to eed9b8b Compare September 26, 2023 18:34
@dashpole
Copy link
Contributor Author

@pellared I wanted to make the example print something out to the console, but that requires importing the stdoutmetric package. Is there a way to add dependencies only for the example?

@pellared
Copy link
Member

@pellared I wanted to make the example print something out to the console, but that requires importing the stdoutmetric package. Is there a way to add dependencies only for the example?

No 😢 We had the same problem in the sdk/metric example. We decided to simply use a ManualReader instead. See https://github.com/open-telemetry/opentelemetry-go/blob/9bbefc6cc31995c7bdd37c69eb153fc2201c3562/sdk/metric/example_test.go#L47-L50

@dashpole dashpole marked this pull request as ready for review September 26, 2023 20:17
@dashpole dashpole requested a review from a team as a code owner September 26, 2023 20:17
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion. Awaiting for a non-Splunk approval.

bridges/prometheus/example_test.go Outdated Show resolved Hide resolved
@pellared
Copy link
Member

Should we also add "Bridges" here: https://github.com/open-telemetry/opentelemetry-go-contrib#contents?

dashpole and others added 2 commits September 27, 2023 09:28
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@dashpole
Copy link
Contributor Author

Should we also add "Bridges" here: https://github.com/open-telemetry/opentelemetry-go-contrib#contents?

Done 35c2be6

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #4348 (050b03a) into main (1855863) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4348   +/-   ##
=====================================
  Coverage   82.2%   82.3%           
=====================================
  Files        144     144           
  Lines      10002   10002           
=====================================
+ Hits        8229    8232    +3     
+ Misses      1634    1632    -2     
+ Partials     139     138    -1     

see 1 file with indirect coverage changes

@pellared pellared merged commit 074ac11 into open-telemetry:main Oct 9, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bridges/prometheus: Refine documentation
4 participants