Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otelgrpc: Modify example to use grpc.StatsHandler #4325

Merged
merged 3 commits into from Sep 22, 2023
Merged

otelgrpc: Modify example to use grpc.StatsHandler #4325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bad20f
modify otelgrpc example to use stats.Handler
fatsheep9146 Sep 22, 2023
0baa55f
add changelog
fatsheep9146 Sep 22, 2023
1e702e8
Update CHANGELOG.md
pellared Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -14,6 +14,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- Set the description for the `rpc.server.duration` metric in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`. (#4302)
- Add `NewServerHandler` and `NewClientHandler` that return a `grpc.StatsHandler` used for gRPC instrumentation in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`. (#3002)

### Changed

- Use `grpc.StatsHandler` for gRPC instrumentation in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/example`. (#4325)

## [1.19.0/0.44.0/0.13.0] - 2023-09-12

### Added
Expand Down
3 changes: 1 addition & 2 deletions instrumentation/google.golang.org/grpc/otelgrpc/example/client/main.go
View file
Open in desktop
Expand Up @@ -44,8 +44,7 @@ func main() {

var conn *grpc.ClientConn
conn, err = grpc.Dial(":7777", grpc.WithTransportCredentials(insecure.NewCredentials()),
grpc.WithUnaryInterceptor(otelgrpc.UnaryClientInterceptor()),
grpc.WithStreamInterceptor(otelgrpc.StreamClientInterceptor()),
grpc.WithStatsHandler(otelgrpc.NewClientHandler()),
)

if err != nil {
Expand Down
3 changes: 1 addition & 2 deletions instrumentation/google.golang.org/grpc/otelgrpc/example/server/main.go
View file
Open in desktop
Expand Up @@ -140,8 +140,7 @@ func main() {
}

s := grpc.NewServer(
grpc.UnaryInterceptor(otelgrpc.UnaryServerInterceptor()),
grpc.StreamInterceptor(otelgrpc.StreamServerInterceptor()),
grpc.StatsHandler(otelgrpc.NewServerHandler()),
)

api.RegisterHelloServiceServer(s, &server{})
Expand Down