Fix deprecation notices in GCP detector #4257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
added
the
Skip Changelog
dmathieu
approved these changes
Aug 29, 2023
hanyuancheung
approved these changes
Aug 29, 2023
MrAlias
approved these changes
Aug 29, 2023
Codecov Report
@@ Coverage Diff @@
## main #4257 +/- ##
=====================================
Coverage 79.4% 79.4%
=====================================
Files 166 166
Lines 10360 10360
=====================================
+ Hits 8227 8230 +3
+ Misses 1998 1996 -2
+ Partials 135 134 -1
|
jlordiales
pushed a commit
to jlordiales/opentelemetry-go-contrib
that referenced
this pull request
Sep 5, 2023
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to open-telemetry/opentelemetry-go#4470 (review), the deprecation comments aren't properly formatted. It isn't properly formatted in the godocs: https://pkg.go.dev/go.opentelemetry.io/contrib/detectors/gcp#pkg-functions